Skip to content

fix: allow doing oidc callback for a non-authenticated user #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konidev20 merged 2 commits into from
May 14, 2025
Merged

fix: allow doing oidc callback for a non-authenticated user #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ccff5a
fix: allow doing oidc callback for a non-authenticated user
ezhevita Mar 7, 2025
7bed4e8
misc: update changelog
ezhevita May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
* [GH-365](https://github.com/rajanadar/VaultSharp/issues/365) Add new ```transit key type``` values like ```hmac-key```, ```cmac-key``` etc.
* [GH-366](https://github.com/rajanadar/VaultSharp/issues/366) PKI Secrets Engine - return raw cert data, including revocation date

**BUG FIXES:**

* [GH-378](https://github.com/rajanadar/VaultSharp/issues/378) DoOIDCCallbackAsync should be allowed for an unauthenticated client

## 1.17.5.1 (September 18, 2024)

**BUG FIXES:**
Expand Down
2 changes: 1 addition & 1 deletion src/VaultSharp/V1/AuthMethods/JWT/JWTAuthMethodProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public async Task<Secret<AuthInfo>> DoOIDCCallbackAsync(string state, string non

var queryString = "?" + string.Join("&", queryStrings);

return await _polymath.MakeVaultApiRequest<Secret<AuthInfo>>("v1/auth/" + mountPoint.Trim('/') + "/oidc/callback" + queryString, HttpMethod.Get).ConfigureAwait(_polymath.VaultClientSettings.ContinueAsyncTasksOnCapturedContext);
return await _polymath.MakeVaultApiRequest<Secret<AuthInfo>>("v1/auth/" + mountPoint.Trim('/') + "/oidc/callback" + queryString, HttpMethod.Get, unauthenticated: true).ConfigureAwait(_polymath.VaultClientSettings.ContinueAsyncTasksOnCapturedContext);
}
}
}