Add installation hook#9
Open
rajatjindal wants to merge 2 commits into
Open
Conversation
rajatjindal
force-pushed
the
add-installation-hook
branch
from
91011d4 to
01470a8
Compare
alexellis
reviewed
Feb 2, 2019
| twitterClient, twitterClientInitErr = twitter.NewClient() | ||
| } | ||
|
|
||
| // func main() { |
Collaborator
There was a problem hiding this comment.
Maybe this could be removed?
Owner
Author
|
Hi @alexellis thanks for all the feedback you have provided so far. I hope you don't mind reviewing the PR for me. Thanks |
alexellis
reviewed
Feb 2, 2019
| // deprecated and replaced by installation and installation_repositories. But github is still sending integration_installation and | ||
| // integration_installation_repositories and go-github don't understand these. | ||
|
|
||
| switch t { |
Collaborator
There was a problem hiding this comment.
What about removal events? (are they correctly ignored?)
This code should be a function and tested 👍
alexellis
reviewed
Feb 2, 2019
| w.Write([]byte("OK")) | ||
| } | ||
|
|
||
| func handleIssuesEvent(o *github.IssuesEvent) []string { |
Collaborator
There was a problem hiding this comment.
Add a test for this?
Owner
Author
|
thanks for review Alex. I will hold on this one until I add atleast few basic tests. sometime today/tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will make sure we can handle installation and installation_repositories event too. and tweet a welcome msg for the new onboarded projects.