Skip to content

Commit 685ddc4

Browse files
committed
Fix: dashboard domain filters only apply to local cluster
Remote clusters without explicit domain filters now get no filtering instead of inheriting dashboard-level filters. This matches the behavior of other selectors (gateway/ingress/httproute) which already only apply dashboard-level config to the local cluster.
1 parent 16bc17d commit 685ddc4

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

internal/controller/cluster_manager.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -673,16 +673,16 @@ func (m *ClusterManager) getSecretHash(ctx context.Context, dashboard *homerv1al
673673
}
674674

675675
// getDomainFiltersForCluster returns the domain filters to use for a cluster
676-
// If the cluster has its own domain filters, use those; otherwise use the dashboard's
676+
// Local cluster uses dashboard-level filters, remote clusters use their own explicit filters
677677
func (m *ClusterManager) getDomainFiltersForCluster(cluster *ClusterClient, dashboard *homerv1alpha1.Dashboard) []string {
678678
if cluster.ClusterCfg != nil && len(cluster.ClusterCfg.DomainFilters) > 0 {
679679
return cluster.ClusterCfg.DomainFilters
680680
}
681681
if cluster.Name == localClusterName {
682682
return dashboard.Spec.DomainFilters
683683
}
684-
// Remote clusters with no explicit domain filters use dashboard filters
685-
return dashboard.Spec.DomainFilters
684+
// Remote clusters with no explicit domain filters: no filtering (return empty)
685+
return nil
686686
}
687687

688688
// matchesIngressDomainFilters checks if an Ingress matches any of the domain filters

0 commit comments

Comments
 (0)