Convert dedicated dict_key type to a 1-element map#276
Open
kannibalox wants to merge 1 commit intorakshasa:masterfrom
Open
Convert dedicated dict_key type to a 1-element map#276kannibalox wants to merge 1 commit intorakshasa:masterfrom
kannibalox wants to merge 1 commit intorakshasa:masterfrom
Conversation
This shaves 8 bits off a Object. Some of this is immediately made back up by the overhead of dealing with a full-fledged map instead of a pair, but the use of dict_key is largely limited to function definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shaves 8 bits off an Object (48 -> 40). Some of this is immediately made back up by the overhead of dealing with a full-fledged map instead of a pair, but the use of dict_key is largely limited to function definitions.
This is just an initial proof-of-concept, if you don't have any problems with it I can remove the
{is/as}_dict_{key/obj}methods entirely and refactor the rtorrent PR to match.