Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| void set_failed_list(BlockFailed* f) { m_failedList = f; } | ||
|
|
||
| static void create_dummy(BlockTransfer* transfer, PeerInfo* peerInfo, const Piece& piece); | ||
| static void create_dummy(BlockTransfer* transfer, PeerInfo* peerInfo, Piece piece); |
There was a problem hiding this comment.
invalid case style for parameter peerInfo
Suggested change
| static void create_dummy(BlockTransfer* transfer, PeerInfo* peerInfo, Piece piece); | |
| static void create_dummy(BlockTransfer* transfer, PeerInfo* peer_info, Piece piece); |
| void clear(); | ||
|
|
||
| iterator insert(const Piece& piece, uint32_t blockSize); | ||
| iterator insert(Piece piece, uint32_t blockSize); |
There was a problem hiding this comment.
invalid case style for parameter blockSize
Suggested change
| iterator insert(Piece piece, uint32_t blockSize); | |
| iterator insert(Piece piece, uint32_t block_size); |
| // | ||
| // Clean this up, don't use this many arguments. | ||
| PeerConnectionBase* insert(PeerInfo* p, const SocketFd& fd, Bitfield* bitfield, EncryptionInfo* encryptionInfo, ProtocolExtension* extensions) LIBTORRENT_NO_EXPORT; | ||
| PeerConnectionBase* insert(PeerInfo* p, SocketFd fd, Bitfield* bitfield, EncryptionInfo* encryptionInfo, ProtocolExtension* extensions) LIBTORRENT_NO_EXPORT; |
There was a problem hiding this comment.
invalid case style for parameter encryptionInfo
Suggested change
| PeerConnectionBase* insert(PeerInfo* p, SocketFd fd, Bitfield* bitfield, EncryptionInfo* encryptionInfo, ProtocolExtension* extensions) LIBTORRENT_NO_EXPORT; | |
| PeerConnectionBase* insert(PeerInfo* p, SocketFd fd, Bitfield* bitfield, EncryptionInfo* encryption_info, ProtocolExtension* extensions) LIBTORRENT_NO_EXPORT; |
| using base_type::operator[]; | ||
|
|
||
| BlockList(const Piece& piece, uint32_t blockLength); | ||
| BlockList(Piece piece, uint32_t blockLength); |
There was a problem hiding this comment.
invalid case style for parameter blockLength
Suggested change
| BlockList(Piece piece, uint32_t blockLength); | |
| BlockList(Piece piece, uint32_t block_length); |
neheb
force-pushed
the
clka
branch
4 times, most recently
from
9863013 to
07c3100
Compare
Contributor
Author
|
Rebased for license removal. |
Contributor
Author
|
Rebased. |
neheb
force-pushed
the
clka
branch
2 times, most recently
from
787b7f9 to
7b333c3
Compare
Found with -Wclazy-copyable-polymorphic Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with: -Wclazy-range-loop-reference Signed-off-by: Rosen Penev <rosenp@gmail.com>
Found with -Wclazy-function-args-by-value Signed-off-by: Rosen Penev <rosenp@gmail.com>
Contributor
Author
|
Rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.