fix: rejecting mathematically valid BLS12-381 private keys #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralexstokes
reviewed
Jul 18, 2025
|
|
||
| // Use HKDF with the key as input material to perform proper reduction | ||
| // This follows EIP-2333 key generation pattern | ||
| let sk = bls_impl::SecretKey::key_gen(&key_int, &[]).map_err(BLSTError::from)?; |
Owner
There was a problem hiding this comment.
if we want to go this route, we probably want something like this
https://docs.rs/blst/0.3.15/blst/min_pk/struct.SecretKey.html#method.derive_master_eip2333
let me see if there is a better way to expose this though before making any changes
Owner
|
closing in lieu of #421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bug: The ethereum-consensus library's SecretKey::try_from() method was overly strict, rejecting mathematically valid BLS12-381 private keys that exceed the field order instead of performing proper modular reduction.