Skip to content

Set target bitrate without reinitialize#80

Closed
algesten wants to merge 2 commits into
ralfbiedert:masterfrom
algesten:feature/bitrate
Closed

Set target bitrate without reinitialize#80
algesten wants to merge 2 commits into
ralfbiedert:masterfrom
algesten:feature/bitrate

Conversation

@algesten

@algesten algesten commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

This adds a set_target_bitrate on the Encoder, which means the bitrate can be altered while the encoder is running and not just at init time.

@ralfbiedert

Copy link
Copy Markdown
Owner

Thanks! Small nit, should this be called set_bitrate since that's what it is in the Config already?

@ralfbiedert

Copy link
Copy Markdown
Owner

Ah, could you also add a small test triggering this between two frames while the encoder is initialized?

@algesten

algesten commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

Will do! (on both)

@algesten

Copy link
Copy Markdown
Contributor Author

I've hit problems. Setting the bitrate on the fly is giving me an error in the test setup. But I could have sworn this is how we do it in our branch of openh264-rs. I need to investigate if we never hit that code path, and this indeed is not going to work.

@ralfbiedert ralfbiedert added the stale An issue without relevant activity. label Jan 4, 2026
@ralfbiedert

Copy link
Copy Markdown
Owner

I'm closing this as stale for now. Feel free to re-open if there is new progress.

@ralfbiedert ralfbiedert closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale An issue without relevant activity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants