Set target bitrate without reinitialize#80
Closed
algesten wants to merge 2 commits into
Closed
Conversation
Owner
|
Thanks! Small nit, should this be called |
Owner
|
Ah, could you also add a small test triggering this between two frames while the encoder is initialized? |
Contributor
Author
|
Will do! (on both) |
Contributor
Author
|
I've hit problems. Setting the bitrate on the fly is giving me an error in the test setup. But I could have sworn this is how we do it in our branch of openh264-rs. I need to investigate if we never hit that code path, and this indeed is not going to work. |
Owner
|
I'm closing this as stale for now. Feel free to re-open if there is new progress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
set_target_bitrateon theEncoder, which means the bitrate can be altered while the encoder is running and not just at init time.