Lower MSRV from 1.88 to 1.85#91
Merged
Merged
Conversation
Edition 2024 was stabilized in Rust 1.85, and no features from Rust 1.86/1.87/1.88 appear to be used in this crate. This enables packaging in Linux distributions currently shipping Rust 1.85.x (Fedora 42, Debian 13, openSUSE). Fixes ralfbiedert#90
The existing code used features that were stabilized after 1.85: - `is_multiple_of()` (stable since 1.87): replaced with `% 8 == 0` - `as_chunks()` / `as_chunks_mut()` (stable since 1.88): replaced with `chunks_exact()` / `chunks_exact_mut()` and slice-to-array conversion The repo's declared MSRV was inconsistent with the actual code. These changes make the codebase properly compatible with Rust 1.85 as intended.
Contributor
Author
|
CI was failing because the existing codebase used features not available in Rust 1.85:
I've pushed a fix that replaces these with MSRV 1.85 compatible alternatives:
The repo's declared MSRV was already inconsistent with the actual code requirements - this PR now properly addresses that inconsistency. |
Owner
|
While I'm ok being slightly conservative w.r.t. MSRV, and we can merge this PR, I'm not sure distributions shipping a year-old Rust compiler should be the primary motivation for what language features to use. It appears supporting Debian would lock us in with this Rust compiler for 1-2 more years? |
ralfbiedert
added
enhancement
Owner
|
0.9.2 is out. |
Contributor
Author
|
Yes, thanks. This is a good tradeoff considering what it means for adoption IMO. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR lowers the workspace
rust-versionfrom 1.88 to 1.85.Rationale
Impact
This unblocks usage in Linux distributions currently shipping Rust 1.85.x:
Testing
CI should pass on Rust 1.85 since no 1.86+ features are used.
Request
If this change is acceptable, could a new version (0.9.2) be published to crates.io? This would unblock downstream distribution packaging that's currently blocked on the MSRV.
Fixes #90