Skip to content

remove deprecated static fields to avoid deadlock #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove deprecated static fields to avoid deadlock #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
939652c
remove deprecated static fields to avoid deadlock
pstanton Mar 28, 2020
82043fe
Update JsonValue_Test.java
pstanton Mar 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions com.eclipsesource.json/src/main/java/com/eclipsesource/json/JsonValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,27 +63,6 @@
@SuppressWarnings("serial") // use default serial UID
public abstract class JsonValue implements Serializable {

/**
* Represents the JSON literal <code>true</code>.
* @deprecated Use <code>Json.TRUE</code> instead
*/
@Deprecated
public static final JsonValue TRUE = new JsonLiteral("true");

/**
* Represents the JSON literal <code>false</code>.
* @deprecated Use <code>Json.FALSE</code> instead
*/
@Deprecated
public static final JsonValue FALSE = new JsonLiteral("false");

/**
* Represents the JSON literal <code>null</code>.
* @deprecated Use <code>Json.NULL</code> instead
*/
@Deprecated
public static final JsonValue NULL = new JsonLiteral("null");

JsonValue() {
// prevent subclasses outside of this package
}
Expand Down
8 changes: 0 additions & 8 deletions com.eclipsesource.json/src/test/java/com/eclipsesource/json/JsonValue_Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,6 @@

public class JsonValue_Test {

@Test
@SuppressWarnings("deprecation")
public void testConstantsAreLiterals() {
assertEquals(Json.NULL, JsonValue.NULL);
assertEquals(Json.TRUE, JsonValue.TRUE);
assertEquals(Json.FALSE, JsonValue.FALSE);
}

@Test
@SuppressWarnings("deprecation")
public void valueOf_int() {
Expand Down