Skip to content

Bump version to 1.1.5 and add configurable taskbar volume tooltip text for translation purposes - #4499

Closed
Piteriuz wants to merge 2 commits into
ramensoftware:mainfrom
Piteriuz:taskbar-volume-control-per-app-custom-tooltips
Closed

Bump version to 1.1.5 and add configurable taskbar volume tooltip text for translation purposes#4499
Piteriuz wants to merge 2 commits into
ramensoftware:mainfrom
Piteriuz:taskbar-volume-control-per-app-custom-tooltips

Conversation

@Piteriuz

@Piteriuz Piteriuz commented Jun 19, 2026

Copy link
Copy Markdown

Changelog

The volume text supports a {volume} placeholder, for example: Volume: {volume}%.
The default behavior and default tooltip text remain unchanged.
This adds settings for customizing the tooltip text shown by Taskbar Volume Control Per-App.

The new settings allow users to customize the text for:

  • no active audio session
  • muted state
  • volume percentage
  • terse format variants

Mod authorship

If this pull request introduces a new mod, please complete the section below.

This mod was created by:

    • The submitter, without AI assistance
    • The submitter, with AI assistance
    • Claude
    • ChatGPT
    • Gemini
    • Another AI (please specify):
    • Other (please specify):

Please select the options that best apply. Your selection does not affect the acceptance criteria, but it helps reviewers understand the context of the code and provide relevant feedback.

This adds settings for customizing the tooltip text shown by Taskbar Volume Control Per-App.

The new settings allow users to customize the text for:
- no active audio session
- muted state
- volume percentage
- terse format variants

The volume text supports a {volume} placeholder, for example: Volume: {volume}%.

The default behavior and default tooltip text remain unchanged.
Copilot AI review requested due to automatic review settings June 19, 2026 17:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps Taskbar Volume Control Per-App to v1.1.5 and adds new mod settings to make the taskbar volume tooltip text configurable (including a {volume} placeholder) to support translation/customization while keeping the default tooltip behavior unchanged.

Changes:

  • Bump mod version from 1.1.4 → 1.1.5.
  • Add new settings for tooltip text in normal/terse modes (no session, muted, volume).
  • Replace the fixed-size tooltip buffer with std::wstring formatting based on the new settings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread mods/taskbar-volume-control-per-app.wh.cpp

@Piteriuz Piteriuz left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the settings handling to avoid reading std::wstring fields while LoadSettings() may update them from another thread. Settings are now loaded into a local Settings instance and published under a mutex, and taskbar hooks read a local snapshot before using the values.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@m417z

m417z commented Jun 22, 2026

Copy link
Copy Markdown
Member

Only the mod author (in this case, me) can submit mod updates. Please submit your changes at the development repository:
https://github.com/m417z/my-windhawk-mods

@Piteriuz

Copy link
Copy Markdown
Author

Thanks, here you go m417z/my-windhawk-mods#70
I've submitted the changes as a pull request.

@Piteriuz Piteriuz closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants