Getter and Setter of playlist api endpoint#439
Open
tomkimsour wants to merge 5 commits intoramsayleung:masterfrom
Open
Getter and Setter of playlist api endpoint#439tomkimsour wants to merge 5 commits intoramsayleung:masterfrom
tomkimsour wants to merge 5 commits intoramsayleung:masterfrom
Conversation
Owner
|
You could take the
|
Author
|
So no unit testing ? just an example instead ? |
Owner
|
The example acts like an end-to-end test for the new endpoint, because as we discussed in this issue: #154 (comment), there is no workable approach for us to run unit test. |
1512ac3 to
7cf76ca
Compare
140ecd0 to
b6370ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed
Getter and setter for playlist cover are missing as mentioned here #377 and #438
Motivation and Context
Please also include relevant motivation and context.
Dependencies
None
Type of change
Please delete options that are not relevant.
How has this been tested?
I am yet trying to test both function under test_with_oauth.rs by creating a playlist, adding a cover, retrieving it and comparing both.
However I need guidance on how to test it as I am not able to figure out how to oauth for the tests. I am not sure what are the variable values required in the .env and even if I put a wrong value, it doesn't seem like the value is being read.
Is this change properly documented?
yes