Fix: accept both item(s) and track(s) from playlist(_items) endpoints#560
Conversation
Spotify now seems to send both items and tracks for the me/playlists endpoint, which currently fails to deserialize, as both map the the same struct field. Instead deserialize them seperately in shadow, and then map them to the real struct.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to add backward compatibility for recent field name changes in the Spotify API, specifically from track(s) to item(s). The implementation for SimplifiedPlaylist is correct. However, there's a logic error in the implementation for PlaylistItem that breaks backward compatibility for the deprecated track field. I've left a comment with a suggested fix.
Description
Spotify now seems to send both items and tracks for the playlists and playlist items endpoints, which currently fails to deserialize, as both map the the same struct field. Instead deserialize them seperately in shadow, and then map them to the real struct.
Motivation and Context
My app got errors for these items
Type of change
The app mentioned above, now works :)
Is this change properly documented?
Yup, updated the changelog