fix: allow both items and tracks in FullPlaylist#563
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the FullPlaylistShadow model to handle both items and tracks fields as optional, providing better compatibility with Spotify API responses. The From implementation now prioritizes items but falls back to tracks. Additionally, a new test case was added to verify this logic, along with minor whitespace cleanups in existing tests. Feedback was provided to improve the readability of the newly added test by shortening excessively long and repetitive JSON arrays.
Owner
|
The CI is failing, the rest looks good to me |
Owner
|
The |
ramsayleung
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spotify now also send both items and tracks for FullPlaylist, handle this when deserializing.
Type of change
How has this been tested?
I have not been able to test this in practice, because I got hit with a 24h ratelimit, but I have added a test using the example response from the spotify api website.
Is this change properly documented?
Yes, see CHANGELOG.md