Skip to content

Allow brick/math 0.13 #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Allow brick/math 0.13 #589

wants to merge 1 commit into from

Conversation

derrabus
Copy link

@derrabus derrabus commented Mar 4, 2025

Description

This PR changes the composer.json file in order to allow the installation of this package alongside the new 0.13 release of the brick/math library. I believe that the UUID library is not affected by the breaking changes that are documented for the 0.13 release.

Motivation and context

A new version of the brick/math library has been released and development will continue on that branch.

How has this been tested?

I ran the PHPUnit tests. The existing tests should cover the integration of the library well, so no new tests have been added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@derrabus derrabus requested a review from ramsey as a code owner March 4, 2025 08:56
@ekvedaras
Copy link

Can we get a merge please? 🙏 Ty 🙂

@kontoulis
Copy link

kontoulis commented Mar 18, 2025

+1
Right now it is not possible to use this alongside https://github.com/ramsey/identifier due to this dependency constraint.
I understand that identifier would be a replacement, but in my case for example I just need to work with snowflakes without touching the rest of the system which uses uuid.

@derrabus derrabus mentioned this pull request Mar 26, 2025
7 tasks
@Jean-Gian
Copy link

I quote @ekvedaras

Can we get a merge please? 🙏 Ty 🙂

@Chris53897
Copy link
Contributor

@ramsey Do you have some time to have a look a rerun ci and maybe make a new version if this PR is fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants