Open
Conversation
0.15 removed the 'old' rounding mode constants, so this includes a BC layer in the `BrickMathCalculator`
|
After creating PR #634 for the By the way, is there an ETA for the v5 release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.15 removed the 'old' rounding mode constants, so this includes a BC layer in the
BrickMathCalculatorDescription
This MR allows installation of brick math versions 0.15 and 0.16.
0.14 changed the rounding mode to an enum, but kept backwards compatability. in 0.15 this BC layer was removed.
To support older brick/math versions (and older PHP versions), we introduce a BC layer in the
BrickMathCalculatorclass.Motivation and context
How has this been tested?
I have ran the phpunit tests with brick/math 0.14, 0.15 and 0.16.
Types of changes
PR checklist
PHPUnit test are working for this MR, but there are some PHPStan failures. I'm not sure how to move forward with those.