Skip to content

Conversation

@R5dan
Copy link
Contributor

@R5dan R5dan commented Jan 23, 2025

  • Adds functions to Search which updates only that field:

    • search_quotes
    • search_news
    • search_lists
    • search_nav
    • search_research
  • Adds a cache to Search

  • Moves fetch to SearchCache

@R5dan R5dan changed the base branch from main to dev January 24, 2025 17:05
@ValueRaider
Copy link
Collaborator

What does SearchCache do that can't be done with request_cache?

@R5dan
Copy link
Contributor Author

R5dan commented Jan 25, 2025

What does SearchCache do that can't be done with request_cache?

To be honest I'd forgotten about it, but looking at it now:

  • requests-cache is an extra, where I think this should be a core functionality as this is more so to save time in the request as the actual response won't change for a few days - (months or years for tickers)

Also why is nospam and extra? I feel like it should be default behavior

@ValueRaider
Copy link
Collaborator

It's extra because not required to fetch data from Yahoo.

Remove SearchCache
@R5dan
Copy link
Contributor Author

R5dan commented Feb 25, 2025

@ValueRaider how is this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants