Skip to content

Fix raising errors instead of just logging them by propagating raise_errors in _lazy_load_price_history #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −8
Open

Fix raising errors instead of just logging them by propagating raise_errors in _lazy_load_price_history #2543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions yfinance/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,17 @@ def __init__(self, ticker, session=None, proxy=_SENTINEL_):

@utils.log_indent_decorator
def history(self, *args, **kwargs) -> pd.DataFrame:
return self._lazy_load_price_history().history(*args, **kwargs)
raise_errors = kwargs.get('raise_errors', False)
return self._lazy_load_price_history(raise_errors).history(*args, **kwargs)

# ------------------------

def _lazy_load_price_history(self):
def _lazy_load_price_history(self, raise_errors=False):
if self._price_history is None:
self._price_history = PriceHistory(self._data, self.ticker, self._get_ticker_tz(timeout=10))
self._price_history = PriceHistory(self._data, self.ticker, self._get_ticker_tz(timeout=10, raise_errors=raise_errors))
return self._price_history

def _get_ticker_tz(self, timeout):
def _get_ticker_tz(self, timeout, raise_errors=False):
if self._tz is not None:
return self._tz
c = cache.get_tz_cache()
Expand All @@ -119,7 +120,7 @@ def _get_ticker_tz(self, timeout):
tz = None

if tz is None:
tz = self._fetch_ticker_tz(timeout)
tz = self._fetch_ticker_tz(timeout, raise_errors)
if tz is None:
# _fetch_ticker_tz works in 99.999% of cases.
# For rare fail get from info.
Expand All @@ -141,7 +142,7 @@ def _get_ticker_tz(self, timeout):
return tz

@utils.log_indent_decorator
def _fetch_ticker_tz(self, timeout):
def _fetch_ticker_tz(self, timeout, raise_errors=False):
# Query Yahoo for fast price data just to get returned timezone
logger = utils.get_yf_logger()

Expand All @@ -157,8 +158,11 @@ def _fetch_ticker_tz(self, timeout):
# Must propagate this
raise
except Exception as e:
logger.error(f"Failed to get ticker '{self.ticker}' reason: {e}")
return None
if raise_errors:
raise e
else:
logger.error(f"Failed to get ticker '{self.ticker}' reason: {e}")
return None
else:
error = data.get('chart', {}).get('error', None)
if error:
Expand Down