Skip to content

fix timezone convert bug in utils._parse_user_dt #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix timezone convert bug in utils._parse_user_dt #2574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import unittest

from yfinance.utils import is_valid_period_format, _dts_in_same_interval
from yfinance.utils import is_valid_period_format, _dts_in_same_interval, _parse_user_dt


class TestPandas(unittest.TestCase):
Expand Down Expand Up @@ -169,6 +169,19 @@ def test_minute_intervals(self):
dt3 = pd.Timestamp("2024-10-15 10:31:00")
self.assertFalse(_dts_in_same_interval(dt1, dt3, "1min"))

class TestParseUserDateTimeCheck(unittest.TestCase):
def test_exchange_timezone(self):
dt1 = pd.Timestamp("2025-07-30 9:00:00")
dt2 = _parse_user_dt(int(dt1.timestamp()), exchange_tz="US/Eastern")
dt3 = _parse_user_dt(int(dt1.timestamp()), exchange_tz="Asia/Tokyo")
dt4 = _parse_user_dt(int(dt1.timestamp()), exchange_tz="US/Pacific")
dt5 = _parse_user_dt(dt4, exchange_tz="Hongkong")
self.assertEqual(int(dt1.timestamp()), int(dt2.timestamp()))
self.assertEqual(int(dt1.timestamp()), int(dt3.timestamp()))
self.assertEqual(int(dt1.timestamp()), int(dt4.timestamp()))
self.assertEqual(int(dt1.timestamp()), int(dt5.timestamp()))


if __name__ == "__main__":
unittest.main()

Expand Down
2 changes: 1 addition & 1 deletion yfinance/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ def snake_case_2_camelCase(s):
def _parse_user_dt(dt, exchange_tz):
if isinstance(dt, int):
# Should already be epoch, test with conversion:
dt = _pd.Timestamp(_datetime.datetime.fromtimestamp(dt)).tz_localize("UTC").tz_convert(exchange_tz)
dt = _pd.Timestamp(_datetime.datetime.fromtimestamp(dt, tz=_datetime.timezone.utc)).tz_convert(exchange_tz)
else:
# Convert str/date -> datetime, set tzinfo=exchange, get timestamp:
if isinstance(dt, str):
Expand Down