Dashboard: Embed into steve#10249
Draft
mook-as wants to merge 3 commits intorancher-sandbox:mainfrom
Draft
Conversation
If the environment variable `RD_DEPMAN_LOCAL_CHANGES` is set, `rddepman` will now make the local changes to update the dependency manifest without attempting to create the pull requests. This is to make it easier to test changes locally by making a fork of the relevant repos and updating the dependencies to use those forks. Signed-off-by: Mark Yen <mark.yen@suse.com>
This converts Rancher Desktop to use steve with embedded dashboard, instead of manually running a second server to handle the static assets. Since we already need to run a standalone forked steve, this makes it easier without significantly making anything more difficult. Note that the copy of steve we are using is already significantly outdated (as is the copy of dashboard), so we will need to update those at some point. Signed-off-by: Mark Yen <mark.yen@suse.com>
This was used by the dashboard server, which we no longer have. We still use express for the HTTP command server (for rdctl). Signed-off-by: Mark Yen <mark.yen@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how we ship the dashboard to have steve handle serving the static assets. This means we can drop the internal dashboard server, making running the dashboard slightly easier.
Also includes a commit to make testing dependencies easier (by having rddepman right out the manifest changes without making PRs).
Note that this is missing the changes to the manifest to use the new steve; this should not be undrafted until rancher-sandbox/rancher-desktop-steve#11 is merged and we have a new steve release. I have been testing with builds from https://github.com/mook-as/rancher-desktop-steve/releases/tag/v0.1.0-beta9.2