BATS: helm-install-rancher: wait for Available instead of helm --wait#10366
Merged
mook-as merged 1 commit intoMay 27, 2026
Merged
Conversation
The rancher Deployment uses the default `progressDeadlineSeconds` (10m), which is shorter than the initial `rancher/rancher` image pull (~487 MB) on slow networks (notably WSL2 on Windows). When that deadline lapses, Kubernetes marks the Deployment Failed with `ProgressDeadlineExceeded`; `helm --wait` reads that condition and bails out before its own `--timeout` would have allowed the pull to complete. Drop `helm --wait` and wait on `Available` directly with `kubectl wait --for=condition=Available --timeout=30m`. `Available` is driven by Ready replica count and is unaffected by `ProgressDeadlineExceeded`, so once the pull eventually completes and the pod goes Ready the wait succeeds. Also `--set replicas=1` since this is a single-node cluster — running three Rancher replicas adds no test coverage and consumes scarce VM memory. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
force-pushed
the
bats-helm-rancher-progress-deadline
branch
from
20d4400 to
d742a10
Compare
mook-as
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
progressDeadlineSeconds(10m), which is shorter than the initialrancher/rancherimage pull (~487 MB) on slow networks (notably WSL2 on Windows). When the deadline lapses Kubernetes marks the DeploymentFailedwithProgressDeadlineExceeded, andhelm --waitreads that and bails out before its own--timeoutwould have allowed the pull to complete.helm --waitand wait on the Deployment'sAvailablecondition directly withkubectl wait --for=condition=Available --timeout=30m.Availableis driven by Ready replica count and is unaffected byProgressDeadlineExceeded, so once the image pull eventually completes and the pod goes Ready the wait succeeds.--set replicas=1since this is a single-node cluster — running three Rancher replicas adds no test coverage and just consumes scarce VM memory.Symptom before the fix
On a Windows runner,
deploy_rancherconsistently failed:while
k3s.logshowed therancher/rancher:v2.11.0image still downloading at ~700 kB/s; the 487 MB pull took ~11 minutes vs the chart Deployment's 10 minute progress deadline.