build(deps-dev): bump electron-builder from 25.1.8 to 26.0.12#8443
build(deps-dev): bump electron-builder from 25.1.8 to 26.0.12#8443
Conversation
dependabot
bot
added
the
component/dependencies
|
Looks fine, but I don't see a release yet: https://github.com/electron-userland/electron-builder/releases/tag/v26.0.12 Let's wait a bit and see if that shows up. |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/electron-builder-26.0.12
branch
2 times, most recently
from
2d4b6aa to
0caeb6b
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/electron-builder-26.0.12
branch
3 times, most recently
from
4058f57 to
0798d10
Compare
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/electron-builder-26.0.12
branch
2 times, most recently
from
2fce659 to
68368f8
Compare
|
I see a release now: https://github.com/electron-userland/electron-builder/releases/tag/v26.0.12 @dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/electron-builder-26.0.12
branch
from
68368f8 to
5562de7
Compare
|
This breaks macOS signing: https://github.com/rancher-sandbox/rancher-desktop/actions/runs/14502897292/job/40687611806 Looking into it; but it's basically because they switched the |
|
I forgot to trigger a package (with signing) test run after the latest changes: |
Bumps [electron-builder](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-builder) from 25.1.8 to 26.0.12. - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-builder/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/v26.0.12/packages/electron-builder) --- updated-dependencies: - dependency-name: electron-builder dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Electron-builder v26.0.10 changed their plist implementation, and it is no longer possible to remove Info.plist keys by setting the value to null. Manually replicate the functionality using an afterPack hook to edit the plist file instead. Signed-off-by: Mark Yen <mark.yen@suse.com>
mook-as
force-pushed
the
dependabot/npm_and_yarn/electron-builder-26.0.12
branch
from
c8511a7 to
6075f3a
Compare
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
Thanks, LGTM
I've not tested the code, but the changes look good to me. I assume you have verified that the package still installs and no longer has the usage description strings.
|
Yeah, I manually checked the built result (before the rebase). |
2 participants
Bumps electron-builder from 25.1.8 to 26.0.12.
Changelog
Sourced from electron-builder's changelog.
... (truncated)
Commits
44c5265chore(deploy): Release v26.0.12 (#8949)e4d00c6chore(deploy): Release v26.0.11 (electron-updater@6.6.2) (#8930)3792826chore(deploy): Release v26.0.10 (electron-updater@6.6.1) (#8912)ea86783chore(deploy): Release v26.0.9 (#8891)d26efc0chore(deploy): Release v26.0.8 (#8878)48c9f88feat: allow usage of.cjs,.mjs, andtype=modulecustom publishers. Add...9bca417chore(deploy): Release v26.0.7 (electron-updater@6.6.0) (#8866)f4fc04achore(deploy): Release v26.0.6 (#8848)e0c1a19chore(deploy): Release v26.0.5 (#8847)6ac8f91chore(deploy): Release v26.0.4 (#8840)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)