Conversation
|
The description includes an "info" icon that doesn't seem to be doing anything. And the line needs to be separated from the radio button group above:
Should looks similar to container engine type and WASM support:
So maybe use the same idea, moving the text to the title, and just using "Enabled" for the checkbox? I don't think we want to follow the naming convention and append a |
| run ctrctl run \ | ||
| --volume "$HOST_WORK_PATH:/mount:rw" --pull never \ | ||
| rd_bats_volume_inotify | ||
| assert_output --regexp "/mount.*foo" |
There was a problem hiding this comment.
It is probably good enough as-is, but I think it becomes clearer when you specify the full line:
| assert_output --regexp "/mount.*foo" | |
| assert_line "/mount/ ATTRIB foo" |
There was a problem hiding this comment.
I think that is too rigid; if we later get proper MODIFY instead of ATTRIB, that should still pass.
jandubois
left a comment
jandubois
left a comment
There was a problem hiding this comment.
If we want to keep the tooltip, we should use the same icon we use elsewhere:
|
I don't know what to do about it, but having inotify enabled results in a bunch of popups from Rancher Desktop requesting access to various protected folders, including Music and Photos libraries. I can't think of a robust way to deal with this. 😞 I mean, we could try bind-mounting some directories read-only into themselves, but that feels brittle/hacky. |
|
Current screenshot: |
This adds the hooks to allow the user to experimentally enable Lima's `mountInotify` setting. Signed-off-by: Mark Yen <mark.yen@suse.com>
Signed-off-by: Mark Yen <mark.yen@suse.com>
Don't use a tooltip for inotify description; having two icons next to the option is too confusing. Signed-off-by: Mark Yen <mark.yen@suse.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
3 participants
This adds an experimental setting to enable inotify support (only on darwin/linux), using the support that Lima already provides.
Includes a BATS test (in a second commit).
Fixes #8717