-
Notifications
You must be signed in to change notification settings - Fork 4
feat: store workload policy status in agent #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8c727ee to
b2fd829
Compare
b2fd829 to
00a2b17
Compare
Signed-off-by: Kyle Dong <[email protected]>
00a2b17 to
832c6d7
Compare
holyspectral
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like much more than just storing the policy status in agent! It generally looks good to me. I think some improvement can be done as to how we deal with rollback.
Signed-off-by: Kyle Dong <[email protected]>
holyspectral
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The only nit is that the last commit shouldn't be a chore. lol Other than that it looks great.
What this PR does / why we need it:
Which issue(s) this PR fixes
fixes #174
Special notes for your reviewer:
Checklist: