chore: bump prerelease versions for prerelease#510
Merged
holyspectral merged 1 commit intoApr 9, 2026
Merged
Conversation
Member
|
I would like the upstream issue to be addressed but we can also do this meanwhile. |
flavio
approved these changes
Apr 1, 2026
kyledong-suse
approved these changes
Apr 1, 2026
Collaborator
Author
|
I found some issue in this PR. I'll change this to draft for now. |
Signed-off-by: Sam Wang (holyspectral) <sam.wang@suse.com>
aa29b4b to
0b0fc11
Compare
Collaborator
Author
|
Thanks for your patience. I've updated this PR to correctly bump chart versions for pre-release. Please take a look again. |
0b0fc11 to
8f1f42f
Compare
Andreagit97
reviewed
Apr 7, 2026
Andreagit97
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this!
It seems the 2 files helm-chart-update-prerelease.yaml and helm-chart-update.yaml are nearly identical
diff --git a/updatecli/updatecli.release.d/helm-chart-update-prerelease.yaml b/updatecli/updatecli.release.d/helm-chart-update.yaml
index 8a96101..892840d 100644
--- a/updatecli/updatecli.release.d/helm-chart-update-prerelease.yaml
+++ b/updatecli/updatecli.release.d/helm-chart-update.yaml
@@ -1,4 +1,4 @@
-name: Update RuntimeEnforcer prerelease chart versions
+name: Update RuntimeEnforcer chart versions
sources:
chartVersion:
@@ -43,23 +43,23 @@ scms:
footers: "Signed-off-by: RuntimeEnforcer bot <runtime-enforcer-bot@users.noreply.github.com>"
conditions:
- prerelease:
- name: Check if the latest runtime-enforcer release is a pre-release.
+ release:
+ name: Check if the latest runtime-enforcer release is a official release
disablesourceinput: true
kind: shell
spec:
- command: 'echo {{ source `releaseVersion` }} | grep -E "v[0-9]+\.[0-9]+\.[0-9]+-([0-9A-Za-z-]+\.)*[0-9A-Za-z-]+"'
+ command: '! echo {{ source `releaseVersion` }} | grep -E "v[0-9]+\.[0-9]+\.[0-9]+-([0-9A-Za-z-]+\.)*[0-9A-Za-z-]+"'
actions:
default:
- title: 'chore: helm chart {{ source "chartVersion" }}-prerelease-{{ source "releaseVersion" }} release'
+ title: 'chore: helm chart {{ source "chartVersion" }} release'
kind: github/pullrequest
scmid: default
spec:
automerge: false
mergemethod: squash
description: |
- Automatic Helm chart {{ source "chartVersion" }}-prerelease-{{ source "releaseVersion" }} update.
+ Automatic Helm chart {{ source "chartVersion" }} update.
This PR has been created by the automation used to automatically update the Helm charts when RuntimeEnforcer is released or helm chart content is updated.
REMEMBER IF YOU WANT TO MERGE IN A SINGLE COMMIT CHANGES AND VERSION BUMP, YOU MUST SQUASH THE COMMIT BEFORE MERGING THIS PR!
draft: false
@@ -71,11 +71,10 @@ targets:
scmid: default
name: update Helm chart version
kind: yaml
- disablesourceinput: true
+ sourceid: chartVersion
spec:
file: charts/runtime-enforcer/Chart.yaml
key: $.version
- value: '{{ source "chartVersion" }}-prerelease-{{ source "releaseVersion" }}'
update_appversion:
scmid: default
name: update Helm chart appVersionDo you think there is a way to have just one file?
Collaborator
Author
|
After checking, while we may be able to dedup to some degree via a values.yaml, this can make it overly complicated than necessary. After discussed with team, I'll keep it as it is. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
===Updated Apr. 02===
The previous approach doesn't consider the updatecli PR to update chart version. A separate updatecli file is added to make sure we can bump chart version for pre-release as well.
0.5.0 => 0.13.0-rc1
PR to bump a pre-release version: holyspectral#38
0.13.0-rc1 => 0.13.0-rc2
PR to bump a pre-release version: holyspectral#39
0.13.0-rc2 => 0.13.0
PR to bump a official version: https://github.com/holyspectral/runtime-enforcer/pull/40/changes
=== V1 ===
Enable publishing pre-release charts.
Which issue(s) this PR fixes
fixes #
Special notes for your reviewer:
Checklist: