Skip to content

fix: adding support for nodeSelector with runtime-enforcer debugger deployment#550

Closed
venkateshjayagopal wants to merge 2 commits into
rancher-sandbox:mainfrom
venkateshjayagopal:main
Closed

fix: adding support for nodeSelector with runtime-enforcer debugger deployment#550
venkateshjayagopal wants to merge 2 commits into
rancher-sandbox:mainfrom
venkateshjayagopal:main

Conversation

@venkateshjayagopal
Copy link
Copy Markdown
Collaborator

@venkateshjayagopal venkateshjayagopal commented Apr 15, 2026

What this PR does / why we need it:

Need support for nodeSelector attribute for debugger deployment

Which issue(s) this PR fixes

fixes #548

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@venkateshjayagopal venkateshjayagopal changed the title Adding support for nodeSelector with runtime-enforcer debugger deployment fix: adding support for nodeSelector with runtime-enforcer debugger deployment Apr 15, 2026
Copy link
Copy Markdown
Collaborator

@holyspectral holyspectral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Just a small copy-paste error. Would you please also add a unit-test for debugger to cover the nodeSelector field? You can check the tests under charts/runtime-enforcer/tests/ for reference.

Comment thread charts/runtime-enforcer/templates/debugger/deployment.yaml Outdated
@venkateshjayagopal
Copy link
Copy Markdown
Collaborator Author

Helm chart unittest results

root@masternode:~/runtime-enforcer-vj/charts/runtime-enforcer# helm unittest .

### Chart [ runtime-enforcer ] .

 PASS  Agent DaemonSet Tests    tests/daemonset_test.yaml
 PASS  Debugger Deployment Tests        tests/deployment_debugger_test.yaml
 PASS  Controller Deployment Tests      tests/deployment_test.yaml
 PASS  Controller PDB Tests     tests/pdb_test.yaml
 PASS  Service Account Tests    tests/serviceaccount_test.yaml
 PASS  VAP Pod Policy Validation Tests  tests/vap_pod_policy_validation_test.yaml

Charts:      1 passed, 1 total
Test Suites: 6 passed, 6 total
Tests:       39 passed, 39 total
Snapshot:    0 passed, 0 total
Time:        334.150512ms

root@masternode:~/runtime-enforcer-vj/charts/runtime-enforcer#

Copy link
Copy Markdown
Collaborator

@holyspectral holyspectral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the unit test! Just another typo probably from copy&paste. Other than that it looks good to me!

Comment thread charts/runtime-enforcer/tests/deployment_debugger_test.yaml
Copy link
Copy Markdown
Collaborator Author

@venkateshjayagopal venkateshjayagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Collaborator

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There is just a conflict in the values file

…eployment

Signed-off-by: Venkatesh Jayagopal <venkatesh.jayagopal@suse.com>
Signed-off-by: Venkatesh Jayagopal <venkatesh.jayagopal@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: provide nodeSelector attribute for debugger deployment in values.yaml

3 participants