fix: adding support for nodeSelector with runtime-enforcer debugger deployment#550
Closed
venkateshjayagopal wants to merge 2 commits into
Closed
fix: adding support for nodeSelector with runtime-enforcer debugger deployment#550venkateshjayagopal wants to merge 2 commits into
venkateshjayagopal wants to merge 2 commits into
Conversation
428fb56 to
11ff002
Compare
holyspectral
previously requested changes
Apr 16, 2026
Collaborator
holyspectral
left a comment
There was a problem hiding this comment.
Thanks for working on this! Just a small copy-paste error. Would you please also add a unit-test for debugger to cover the nodeSelector field? You can check the tests under charts/runtime-enforcer/tests/ for reference.
36074d6 to
55b251e
Compare
Collaborator
Author
|
Helm chart unittest results |
55b251e to
5a73115
Compare
Collaborator
holyspectral
left a comment
There was a problem hiding this comment.
Thanks for adding the unit test! Just another typo probably from copy&paste. Other than that it looks good to me!
a0598e7 to
f40e47e
Compare
Andreagit97
reviewed
Apr 17, 2026
dc611ea to
89908af
Compare
…eployment Signed-off-by: Venkatesh Jayagopal <venkatesh.jayagopal@suse.com>
6a3277c to
e07f90d
Compare
Signed-off-by: Venkatesh Jayagopal <venkatesh.jayagopal@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Need support for nodeSelector attribute for debugger deployment
Which issue(s) this PR fixes
fixes #548
Special notes for your reviewer:
Checklist: