chore: rename ubuntu identifiers to opensuse across tests and docs#665
Merged
Andreagit97 merged 2 commits intoJun 4, 2026
Merged
Conversation
…amples Signed-off-by: Alessio Biancalana <alessio.biancalana@suse.com>
Andreagit97
reviewed
Jun 3, 2026
Collaborator
There was a problem hiding this comment.
This is the unique file that shouldn't receive any rename. Please note there are some examples based on the len
// 2. 63 characters
// deployment-name: opensuse-deploymentttttttttttttttttttttttttttttttttttttttttttt
// pod-name: opensuse-deploymenttttttttttttttttttttttttttttttttttttttttq8fcg
// In this case we have just the final [random(q8fcg)] without the `-`. The name of the deployment is truncated.
since opensuse != ubuntu we cannot just rename since it will cause a wrong example. I would suggest to keep ubuntu here
Andreagit97
reviewed
Jun 3, 2026
Collaborator
There was a problem hiding this comment.
also in this file i would probable leave ubuntu we are not deploying anything just using ubuntu as a simple name
…s and samples Signed-off-by: Alessio Biancalana <alessio.biancalana@suse.com>
246db74 to
539ed91
Compare
Andreagit97
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Just renaming the leftovers to openSUSE for consistency :-)
Which issue(s) this PR fixes
fixes #663
Special notes for your reviewer:
Checklist: