Skip to content

chore: rename ubuntu identifiers to opensuse across tests and docs#665

Merged
Andreagit97 merged 2 commits into
rancher-sandbox:mainfrom
dottorblaster:fix-ubuntu-leftovers-opensuse
Jun 4, 2026
Merged

chore: rename ubuntu identifiers to opensuse across tests and docs#665
Andreagit97 merged 2 commits into
rancher-sandbox:mainfrom
dottorblaster:fix-ubuntu-leftovers-opensuse

Conversation

@dottorblaster

@dottorblaster dottorblaster commented Jun 3, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Just renaming the leftovers to openSUSE for consistency :-)

Which issue(s) this PR fixes

fixes #663

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

…amples

Signed-off-by: Alessio Biancalana <alessio.biancalana@suse.com>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the unique file that shouldn't receive any rename. Please note there are some examples based on the len

// 2. 63 characters
	//    deployment-name: opensuse-deploymentttttttttttttttttttttttttttttttttttttttttttt
	//    pod-name: opensuse-deploymenttttttttttttttttttttttttttttttttttttttttq8fcg
	//    In this case we have just the final [random(q8fcg)] without the `-`. The name of the deployment is truncated.

since opensuse != ubuntu we cannot just rename since it will cause a wrong example. I would suggest to keep ubuntu here

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in this file i would probable leave ubuntu we are not deploying anything just using ubuntu as a simple name

…s and samples

Signed-off-by: Alessio Biancalana <alessio.biancalana@suse.com>
@Andreagit97 Andreagit97 merged commit ee1c132 into rancher-sandbox:main Jun 4, 2026
11 of 21 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Review to Done in Runtime Enforcer Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

need to reference opensuse deployment instead of Ubuntu in quick start documentation

2 participants