Skip to content

Conversation

@vardhaman22
Copy link
Contributor

Issue:

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@vardhaman22 vardhaman22 requested a review from a team as a code owner November 7, 2024 14:14
@github-actions
Copy link

github-actions bot commented Nov 7, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

name: rancher-cis-benchmark-crd
type: application
version: 7.0.0-rc.2
version: 7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 7.0.0
version: 105.0.0+7.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done made it 105.0.0+up7.0.0

- security
name: rancher-cis-benchmark
version: 7.0.0-rc.2
version: 7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 7.0.0
version: 105.0.0+7.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

index.yaml Outdated
urls:
- assets/rancher-cis-benchmark/rancher-cis-benchmark-7.0.0-rc.2.tgz
version: 7.0.0-rc.2
- assets/rancher-cis-benchmark/rancher-cis-benchmark-7.0.0.tgz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- assets/rancher-cis-benchmark/rancher-cis-benchmark-7.0.0.tgz
- assets/rancher-cis-benchmark/rancher-cis-benchmark-105.0.0+7.0.0.tgz

index.yaml Outdated
- assets/rancher-cis-benchmark/rancher-cis-benchmark-7.0.0-rc.2.tgz
version: 7.0.0-rc.2
- assets/rancher-cis-benchmark/rancher-cis-benchmark-7.0.0.tgz
version: 7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 7.0.0
version: 105.0.0+7.0.0

index.yaml Outdated
urls:
- assets/rancher-cis-benchmark-crd/rancher-cis-benchmark-crd-7.0.0-rc.2.tgz
version: 7.0.0-rc.2
- assets/rancher-cis-benchmark-crd/rancher-cis-benchmark-crd-7.0.0.tgz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- assets/rancher-cis-benchmark-crd/rancher-cis-benchmark-crd-7.0.0.tgz
- assets/rancher-cis-benchmark-crd/rancher-cis-benchmark-crd-105.0.0+7.0.0.tgz

index.yaml Outdated
- assets/rancher-cis-benchmark-crd/rancher-cis-benchmark-crd-7.0.0-rc.2.tgz
version: 7.0.0-rc.2
- assets/rancher-cis-benchmark-crd/rancher-cis-benchmark-crd-7.0.0.tgz
version: 7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 7.0.0
version: 105.0.0+7.0.0

- security
name: rancher-cis-benchmark
version: 7.0.0-rc.2
version: 7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 7.0.0
version: 105.0.0+7.0.0

@@ -1,5 +1,5 @@
url: local
version: 7.0.0-rc.2
version: 7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 7.0.0
version: 105.0.0+7.0.0

release.yaml Outdated
system-upgrade-controller:
- 105.0.0
rancher-cis-benchmark-crd:
- 7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 7.0.0
- 105.0.0+7.0.0

release.yaml Outdated
rancher-cis-benchmark-crd:
- 7.0.0
rancher-cis-benchmark:
- 7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 7.0.0
- 105.0.0+7.0.0

Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning needs to align with #4685 for this branch.

@vardhaman22 vardhaman22 changed the title [dev-v2.10] rancher-cis-benchmark 7.0.0 unrc [dev-v2.10] rancher-cis-benchmark 105.0.0+up7.0.0 unrc Nov 7, 2024
@vardhaman22
Copy link
Contributor Author

Versioning needs to align with #4685 for this branch.

done

@vardhaman22 vardhaman22 requested a review from pjbgf November 7, 2024 15:59
@github-actions
Copy link

github-actions bot commented Nov 7, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@pjbgf
Copy link
Member

pjbgf commented Nov 7, 2024

@nicholasSUSE please review this one to make sure it will be compatible with the automation going forward.

@nicholasSUSE
Copy link
Collaborator

Please hold on before merging this PR,
Let's try to execute the proper auto-bump process.

See: rancher/cis-operator#442

@nicholasSUSE
Copy link
Collaborator

Closing in favor of: #4685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants