Skip to content

[dev-v2.10] Add chart for Supportability Review Operator #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

masap
Copy link

@masap masap commented Mar 6, 2025

Pull Requests Rules

  • Never remove an already released chart!

    • This does not apply to RC's because they are not released.
  • Each Pull Request should only modify one chart with its dependencies.

  • Pull request title:

    [dev-v2.X] <chart> <version> <action>
    
    • <action>: 1 of (bump; remove; UnRC)

Checkpoints for Chart Bumps

release.yaml:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch or minor version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Chart.yaml and index.yaml:

  • The index.yaml file has an entry for your new chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

Fill the following only if required by your manager.

Issue:

We would like to add our Supportability Review Operator into official Rancher Chart.

Solution

Add chart for Supportability Review Operator.

QA Testing Considerations

cc: @aemneina, @ajithijk

Copy link

github-actions bot commented Mar 6, 2025

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@recena
Copy link
Collaborator

recena commented Mar 8, 2025

⚠️ This new addition must update the CODEOWNER /cc @rancher/release-team

@masap
Copy link
Author

masap commented Mar 12, 2025

@recena

This new addition must update the CODEOWNER

Thank you for comment. Is there anything I should do about this?

Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@masap
Copy link
Author

masap commented Mar 18, 2025

Rebased.

@masap
Copy link
Author

masap commented May 14, 2025

Resubmitted for dev-v2.11 by #5658.

@masap masap closed this May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants