[main] custom host path support #792
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also set privileged false for the pod
vardhaman22
force-pushed
the
custom-volume
branch
from
9243030 to
236e18c
Compare
pjbgf
reviewed
Apr 17, 2025
Comment on lines
+263
to
+264
| if path == "/" { | ||
| return fmt.Errorf("root path '/' is not allowed") |
There was a problem hiding this comment.
Not quite sure we support running it on Windows nodes, either way this looks a bit more future proof:
Suggested change
| if path == "/" { | |
| return fmt.Errorf("root path '/' is not allowed") | |
| if path == "/" || path == "\" { | |
| return fmt.Errorf("root path is not allowed") |
| hostPathSet := make(map[string]bool) | ||
|
|
||
| for _, path := range hostPaths { | ||
| if !filepath.IsAbs(path) { |
There was a problem hiding this comment.
This only checks whether the path is rooted, and therefore would return true for /abc/.../bin. We must call filepath.Clean(path) to ensure that becomes /bin before we do all the checks we are doing here.
Suggested change
| if !filepath.IsAbs(path) { | |
| path = filepath.Clean(path) | |
| if !filepath.IsAbs(path) { |
| } | ||
|
|
||
| for _, protected := range protectedDirs { | ||
| if path == protected || strings.HasPrefix(path, protected+"/") { |
There was a problem hiding this comment.
This will probably not work very well if executed in Windows. Perhaps string(filepath.Separator) could be used instead. Either way, it would be good to have unit tests showing all the inputs and outputs we have considered.
Suggested change
| if path == protected || strings.HasPrefix(path, protected+"/") { | |
| if path == protected || strings.HasPrefix(path, protected+"/") { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.