Skip to content

Render rke2-install without semanage for flatcar #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

k0da
Copy link
Contributor

@k0da k0da commented Apr 28, 2025

What this PR does / why we need it:
Flatcar OS doesn't have semanage due to missing python from base distro. This PR removes semanage command from rke2-install only if additionalIgnition have variant: flatcar set

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@k0da k0da requested a review from a team as a code owner April 28, 2025 09:27
@furkatgofurov7
Copy link
Contributor

@k0da thanks for the PR, can you take a look at linting CI and fix them?

@k0da
Copy link
Contributor Author

k0da commented Apr 29, 2025

@furkatgofurov7 Thanks for review. I've fixed linters.

Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexander-demicev alexander-demicev added this pull request to the merge queue Apr 30, 2025
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Merged via the queue into rancher:main with commit 360c50d Apr 30, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from PR to be reviewed to Done in CAPI / Turtles Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants