Fix nil point dereference in updateStatus method
#638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Furkat Gofurov <[email protected]>
furkatgofurov7
added
area/controller
anmazzotti
approved these changes
Apr 30, 2025
alexander-demicev
approved these changes
May 2, 2025
github-project-automation
bot
moved this from PR to be reviewed
to Done
in CAPI / Turtles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The panic in the logs indicates a nil pointer dereference in the
updateStatusfunction of the RKE2ControlPlaneReconciler, so the changes improve the resilience of the controller by adding additional nil checks, improving error handling, and ensuring graceful handling of edge cases during cluster deletion and reconciliation.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes: #620
Special notes for your reviewer:
Checklist: