Add Gzip Compression Option for User Data #649
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkatgofurov7
added
area/bootstrap
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
2 times, most recently
from
625a518 to
3adebe0
Compare
|
Thanks for accepting this feature request and taking care of the implementation. Could you also add support for compression on ignition-based system as discussed in the issue: #639 (comment) |
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
2 times, most recently
from
4a5be12 to
31b8cb1
Compare
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
from
d86ba39 to
b6d73a2
Compare
Signed-off-by: Furkat Gofurov <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]>
…n field Signed-off-by: Furkat Gofurov <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]> Authored-by: @zioc
Signed-off-by: Furkat Gofurov <[email protected]>
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
from
b6d73a2 to
3737458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a new boolean field,
gzipUserData, in theRKE2ConfigSpec, allowing users to enable gzip compression for cloud-init user data in the RKE2 bootstrap process. This change is based on this commit, where gzip compression was controlled via a custom annotation. The difference is, this solution utilizes a simpler approach based on new boolean field.The new
gzipUserDatafield allows users to enable gzip compression for user data optionally. Few things to highlight:gzipUserDataboolean field in theRKE2ConfigSpec.gzipUserDatais set tofalse, ensuring existing configurations are not affected unless explicitly enabled by the user.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #639
Special notes for your reviewer:
Checklist: