✨ Add Gzip Compression Option for User Data #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkatgofurov7
added
area/bootstrap
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
2 times, most recently
from
625a518 to
3adebe0
Compare
|
Thanks for accepting this feature request and taking care of the implementation. Could you also add support for compression on ignition-based system as discussed in the issue: #639 (comment) |
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
2 times, most recently
from
4a5be12 to
31b8cb1
Compare
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
2 times, most recently
from
b6d73a2 to
3737458
Compare
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
4 times, most recently
from
6f840e4 to
f7c3b80
Compare
Signed-off-by: Furkat Gofurov <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]>
…n field Signed-off-by: Furkat Gofurov <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]>
Signed-off-by: Furkat Gofurov <[email protected]> Authored-by: @zioc
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
4 times, most recently
from
8ce2dab to
10fc55c
Compare
…on of CAPRKE2 is out Signed-off-by: Furkat Gofurov <[email protected]>
furkatgofurov7
force-pushed
the
support-gzip-user-data
branch
from
10fc55c to
099492e
Compare
furkatgofurov7
changed the title
anmazzotti
reviewed
Jul 3, 2025
anmazzotti
previously approved these changes
Jul 3, 2025
Contributor
anmazzotti
left a comment
anmazzotti
left a comment
There was a problem hiding this comment.
Nitpicking the default value for the new field, but rest looks all good. Nice work and thank you for adding the documentation as well!
Signed-off-by: Furkat Gofurov <[email protected]>
anmazzotti
approved these changes
Jul 3, 2025
alexander-demicev
approved these changes
Jul 3, 2025
Member
|
Please open a follow-up issue about tests improvement we discussed yesterday |
salasberryfin
approved these changes
Jul 3, 2025
mjura
approved these changes
Jul 3, 2025
github-project-automation
bot
moved this from PR to be reviewed
to Done
in CAPI / Turtles
Contributor
Author
@alexander-demicev filed #693 to track it. |
furkatgofurov7
added a commit
to furkatgofurov7/cluster-api-provider-rke2
that referenced
this pull request
Aug 22, 2025
…ld in templates New version of CAPRKE2 (v0.19.0) is out, hence we can now remove previous version template introduced in rancher#649 to workaround e2e complications. Signed-off-by: Furkat Gofurov <[email protected]>
4 tasks
furkatgofurov7
added a commit
to furkatgofurov7/cluster-api-provider-rke2
that referenced
this pull request
Aug 26, 2025
…ld in templates New version of CAPRKE2 (v0.19.0) is out, hence we can now remove previous version template introduced in rancher#649 to workaround e2e complications. Signed-off-by: Furkat Gofurov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a new boolean field,
gzipUserData, in theRKE2ConfigSpec, allowing users to enable gzip compression for cloud-init user data in the RKE2 bootstrap process. This change is based on this commit, where gzip compression was controlled via a custom annotation. The difference is, this solution utilizes a simpler approach based on new boolean field.The new
gzipUserDatafield allows users to enable gzip compression for user data optionally. Few things to highlight:gzipUserDataboolean field in theRKE2ConfigSpec.gzipUserDatais set tofalse, ensuring existing configurations are not affected unless explicitly enabled by the user.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #639
Special notes for your reviewer:
Checklist: