✨ Add EncryptionConfig support to RKE2ControlPlane#758
Merged
Conversation
k0da
force-pushed
the
secretsatrest
branch
5 times, most recently
from
099d4e2 to
44689c8
Compare
Contributor
Author
|
E2E tested it: RKE2ControlPlane part: secretsEncryption:
encryptionKeySecret:
name: enc-secret
namespace: xyz-nonprod-4t9jm
provider: secretbox# rke2 secrets-encrypt status
Encryption Status: Enabled
Current Rotation Stage: start
Server Encryption Hashes: All hashes match
Active Key Type Name
------ -------- ----
* XSalsa20-POLY1305 enckey |
k0da
force-pushed
the
secretsatrest
branch
3 times, most recently
from
6f7ac8b to
3d1d6d4
Compare
Contributor
|
@k0da thanks for PR, can you take a look at failing tests and fix them? |
Contributor
Author
I fixed v1alpha1 conversion and run tests locally, they passed now. |
anmazzotti
reviewed
Oct 22, 2025
anmazzotti
previously approved these changes
Oct 23, 2025
Contributor
anmazzotti
left a comment
anmazzotti
left a comment
There was a problem hiding this comment.
Thank you for adding the documentation.
furkatgofurov7
approved these changes
Oct 23, 2025
furkatgofurov7
changed the title
furkatgofurov7
requested changes
Oct 23, 2025
This commit adds RKE2ControlPlane.spec.serverConfig.secretsEncryption property. This allows to specify provider type (aescbc or secretbox) and load encryption key from a secret. Signed-off-by: Dinar Valeev <k0da@opensuse.org>
anmazzotti
approved these changes
Oct 23, 2025
furkatgofurov7
approved these changes
Oct 23, 2025
Contributor
furkatgofurov7
left a comment
furkatgofurov7
left a comment
There was a problem hiding this comment.
@k0da thank you for working on this!
furkatgofurov7
added
area/controlplane
github-project-automation
Bot
moved this from PR to be reviewed
to Done
in CAPI / Turtles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds RKE2ControlPlane.spec.serverConfig.secretsEncryption property.
This allows to specify provider type (aescbc or secretbox) and load encryption key from a secret.
kind/feature
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: