✨ add new bootstrap/control plane API v1beta2
#793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for the new API is added but it is set to `served: false` and `storage: false`. This is done to reduce the size of the PR and sequentially add new changes on top of this scaffolding. Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
changed the title
v1beta2
The code for the new API is added but it is set to `served: false` and `storage: false`. This is done to reduce the size of the PR and sequentially add new changes on top of this scaffolding. Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
new_api_v1beta2
branch
from
731ddd2 to
6c64eb9
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kind/feature
What this PR does / why we need it:
This PR adds a new control plane and bootstrap API
v1beta2. This does not include any relevant changes and is used to break down the changes into multiple PRs, making it easier to review and progress more effectively.Fields that were marked as deprecated in
v1beta1have now been removed.The new API version is not served nor added to storage for now: kubebuilder markers are removed until it is ready to be used.
Which issue(s) this PR fixes:
Fixes #789
Special notes for your reviewer:
It partially addresses #554:
RKE2ControlPlaneSpec.InfrastructureRefis removed.RKE2ControlPlaneSpec.NodeDrainTimeoutis removed.RKE2ControlPlaneMachineTemplateis marked as required.Pending: Conversion and usage will be adapted before the API is served
Checklist: