Skip to content

Cleanup ClusterNetwork handling#861

Merged
salasberryfin merged 1 commit into
rancher:mainfrom
AbsaOSS:cidr
Mar 16, 2026
Merged

Cleanup ClusterNetwork handling#861
salasberryfin merged 1 commit into
rancher:mainfrom
AbsaOSS:cidr

Conversation

@k0da
Copy link
Copy Markdown
Contributor

@k0da k0da commented Mar 13, 2026

Reuse ClusterNetwork .String() function add tests for cluster-cidr and service-cidr

What this PR does / why we need it:

Small improvement in upstream reusability and tests

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Reuse ClusterNetwork .String() function add tests for
cluster-cidr and service-cidr

Signed-off-by: Dinar Valeev <k0da@opensuse.org>
@k0da k0da requested a review from a team as a code owner March 13, 2026 14:32
@kkaempf kkaempf added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 13, 2026
@kkaempf kkaempf moved this to PR to be reviewed in CAPI / Turtles Mar 13, 2026
@kkaempf kkaempf added this to the v0.24.0 (Rancher v2.15.0) milestone Mar 13, 2026
Copy link
Copy Markdown
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @k0da

@salasberryfin salasberryfin enabled auto-merge March 16, 2026 08:41
@salasberryfin salasberryfin added this pull request to the merge queue Mar 16, 2026
Merged via the queue into rancher:main with commit 94f7882 Mar 16, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from PR to be reviewed to Done in CAPI / Turtles Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants