Add support for in-place update contracts#866
Open
alexander-demicev wants to merge 2 commits intorancher:mainfrom
Open
Add support for in-place update contracts#866alexander-demicev wants to merge 2 commits intorancher:mainfrom
alexander-demicev wants to merge 2 commits intorancher:mainfrom
Conversation
alexander-demicev
force-pushed
the
inplaceskeleton
branch
from
13fd601 to
c9f8fa1
Compare
alexander-demicev
force-pushed
the
inplaceskeleton
branch
2 times, most recently
from
47b1180 to
83d72dd
Compare
alexander-demicev
changed the title
alexander-demicev
changed the title
Signed-off-by: Alex Demicev <alex.demicev@lambdal.com>
alexander-demicev
force-pushed
the
inplaceskeleton
branch
from
83d72dd to
d3e479f
Compare
furkatgofurov7
added
area/controlplane
Contributor
|
@alexander-demicev looks like |
Signed-off-by: Alex Demicev <alex.demicev@lambdal.com>
alexander-demicev
force-pushed
the
inplaceskeleton
branch
from
d3e479f to
c557c65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add support for in-place update contracts. It requires some internal CAPI functions to be made public but that's likely not going to happen anytime soon kubernetes-sigs/cluster-api#13507. I added a CAPI package that includes all required code and keeps it separated. We can later drop the package as we make functions public.
The carried code from CAPI is added with a separate commit to make reviews easier.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #865
Special notes for your reviewer:
Checklist: