[release/v1.5] Add image pull secret support#349
Open
Abhishek-Valaboju wants to merge 2 commits into
Open
Conversation
Abhishek-Valaboju
changed the title
Abhishek-Valaboju
force-pushed
the
imagePullSecrets-v1.5
branch
3 times, most recently
from
324ff3a to
6d13e40
Compare
Abhishek-Valaboju
force-pushed
the
imagePullSecrets-v1.5
branch
from
6d13e40 to
8e61592
Compare
There was a problem hiding this comment.
Pull request overview
Adds Helm chart support for configuring imagePullSecrets so the operator, the patch-sa hook Job, and dynamically created scan pods (via compliance-scan-serviceaccount) can pull images from private registries without requiring Go/operator changes.
Changes:
- Introduces a reusable Helm helper to render
imagePullSecretsfromglobal.cattle.imagePullSecrets. - Wires
imagePullSecretsinto the operator Deployment, the patch-sa Job PodSpec, and the scan ServiceAccount. - Bumps chart
version/appVersionand the operator image tag tov1.5.0-rc.4.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| chart/values.yaml | Adds global.cattle.imagePullSecrets and bumps operator tag. |
| chart/templates/_helpers.tpl | Adds helper template to render imagePullSecrets. |
| chart/templates/deployment.yaml | Applies helper output to operator PodSpec. |
| chart/templates/patch_default_serviceaccount.yaml | Applies helper output to patch-sa Job PodSpec. |
| chart/templates/serviceaccount.yaml | Applies helper output to compliance-scan-serviceaccount. |
| chart/Chart.yaml | Bumps chart version and appVersion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HarrisonWAffel
approved these changes
Jun 23, 2026
HarrisonWAffel
left a comment
HarrisonWAffel
left a comment
There was a problem hiding this comment.
LGTM once the existing copilot comment is addressed
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue : rancher/rancher#54979
Add support for imagePullSecrets in the compliance-operator chart.
Changes
Approach
The security scan jobs created by compliance-operator run using the compliance-scan-serviceaccount ServiceAccount (ClusterScanSA).Pods automatically inherit imagePullSecrets configured on their ServiceAccount.
Since the scan jobs already reference compliance-scan-serviceaccount, adding imagePullSecrets to the ServiceAccount allows dynamically created scan pods (security-scan and sonobuoy) to use imagePullSecrets without requiring changes to the operator’s Go code or Job PodSpec generation logic.