Skip to content

automation: select all custom permissions #13892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yonasberhe23
Copy link
Contributor

Summary

Fixes #rancher/qa-tasks#1747

This PR updates an existing test (cypress/e2e/tests/pages/explorer2/cluster-project-members.spec.ts => "Can create a member with custom permissions") to select all custom permissions. Selecting all options will catch issues like #13764

Ignore the test failure in CI as it's expected. A fix is needed for the above issue before merging this code.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@yonasberhe23 yonasberhe23 added this to the v2.12.0 milestone Mar 26, 2025
@yonasberhe23 yonasberhe23 self-assigned this Mar 26, 2025
@rancher-max
Copy link
Member

@git-ival FYI 🎉

Copy link
Member

@rancher-max rancher-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it -- this is some nice test driven development! Thank you!

@rancher-max rancher-max requested a review from IsaSih March 31, 2025 18:38
@yonasberhe23 yonasberhe23 force-pushed the update_project_memb_test branch from 2df66a6 to 5ae51ee Compare April 1, 2025 21:51
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yonasberhe23 yonasberhe23 marked this pull request as draft April 17, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants