[2.10.6] Added error listener to NodeGroups in EKS #14065
+30
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14062
Backport. Added error listener to NodeGroups in EKS. This ensures we don't swallow the errors that happen while fetching LaunchTemplate info
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
EKS creation and edit:
Force a network error while loading launchTemplate versions. (or programmatically throw an error inside fetchLaunchTemplateVersionInfo)
Verify that the error is displayed
Areas which could experience regressions
None
Screenshot/Video
Checklist