Skip to content

Enable Incremental Loading, Manual Refresh and SSP at same time, make FF sole switch for SSP #14086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Apr 10, 2025

Summary

Fixes #14016
Fixes #14087

Contributes to #14034

Occurred changes and/or fixed issues

  • Allow SSP, incremental loading and manual refresh performance settings to be enabled at the same time
    • If a list has SSP enabled it will disable incremental loading and manual refresh features
  • Enable SSP only via Feature Flag (remove SSP enabled/disabled performance setting)
    • Given the backend and frontend changes are so co-dependent now it makes sense to remove this additional step
    • The only thing blocking it was the disabling of incremental loading and manual refresh perf settings which happened when user enabled SSP perf setting. That's no longer required

Technical notes summary

Areas or cases that should be tested

  • Vai off
    • incremental loading and manual refresh perf settings enabled
      • general feature tests
  • Vai on
    • incremental loading and manual refresh perf settings enabled
      • list that is not supported by SSP (fleet, cluster management, etc or hack the pods view) should have both features working
      • list that is supported by SSP (pod) should have both features NOT working (aka not exercised)
        • manual refresh is odd.. because SSP has it's own manual refresh option
    • incremental loading and manual refresh perf settings disabled
      • lists that are supported and not supported by SSP continue to work as required

Areas which could experience regressions

  • Lists
  • Performance Settings View

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@richard-cox richard-cox added this to the v2.12.0 milestone Apr 10, 2025
@richard-cox richard-cox self-assigned this Apr 10, 2025
@richard-cox richard-cox changed the title Enable Incremental Loading and Manual Refresh settings on alongside SSP, make FF sole switch for SSP Enable Incremental Loading and Manual Refresh settings alongside SSP, make FF sole switch for SSP Apr 11, 2025
@richard-cox richard-cox changed the title Enable Incremental Loading and Manual Refresh settings alongside SSP, make FF sole switch for SSP Enable Incremental Loading, Manual Refresh and SSP at same time, make FF sole switch for SSP Apr 11, 2025
@richard-cox richard-cox changed the title Enable Incremental Loading, Manual Refresh and SSP at same time, make FF sole switch for SSP Enable Incremental Loading, Manual Refresh and SSP at same time, make FF sole switch for SSP Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant