Update formatSubnetworkOptions to prioritize selfLink over network #16053
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
| wrapper.setProps({ network: 'host-shared-vpc' }); | ||
| await wrapper.vm.$nextTick(); | ||
| expect(wrapper.emitted('update:subnetwork')?.[0]?.[0]).toBe('projects/host-project-309915/regions/us-west1/subnetworks/host-shared-vpc-us-west1-subnet-public'); | ||
| expect(wrapper.emitted('update:subnetwork')?.[0]?.[0]).toBe('projects/host-project-309915/global/networks/host-shared-vpc'); |
Member
There was a problem hiding this comment.
I think this is indicative of something wrong with the networking code. I would still expect the emitted event here to refer to a subnetwork selfLink, since one was defined previously and mock data hasn't changed, but that's a network selfLink. Looking at gcp mock data, sn.subnetwork is defined when the user has selected a shared VPC. I think #16052 is not needed in light of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16052
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist
Admin,Standard UserandUser Base