Prevent PRs from merging if they do not track the correct milestone for the target branch #16064
+108
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- current plan is one file in master - ties r/d repos to a rancher milestone - includes other useful data for other use cases - e2e docker image - ui-dashboard-index/ui-index values to use for specific rancher branches
…or the target branch
9 tasks
richard-cox
commented
Nov 27, 2025
| if (prMilestoneTitle === expectedMilestone) { | ||
| core.info(`✅ Milestone '${prMilestoneTitle}' matches the expected branch milestone '${expectedMilestone}'.`); | ||
| } else { | ||
| core.setFailed(`❌ Pull Request milestone '${prMilestoneTitle}' does not match the expected milestone '${expectedMilestone}' for the target branch '${prTargetBranch}'. Please update the PR milestone.`); |
Member
Author
There was a problem hiding this comment.
Suggested change
| core.setFailed(`❌ Pull Request milestone '${prMilestoneTitle}' does not match the expected milestone '${expectedMilestone}' for the target branch '${prTargetBranch}'. Please update the PR milestone.`); | |
| core.setFailed(`❌ Pull Request milestone '${prMilestoneTitle}' does not match the required milestone '${expectedMilestone}' for the target branch '${prTargetBranch}'`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #16061 (required json file rename as well)
Summary
Ensure a PR cannot merge if it's target branch does not track the PRs target milestone
This can work alongside the concept of code freeze, specifically to support the use case of merging future work to master when master is not in code freeze
Occurred changes and/or fixed issues
Checklist
Admin,Standard UserandUser Base