Skip to content

Automation: Stabilize OIDC provider tests#17032

Merged
yonasberhe23 merged 1 commit into
rancher:masterfrom
yonasberhe23:fix_oidc_provider_test_failures_215
Mar 28, 2026
Merged

Automation: Stabilize OIDC provider tests#17032
yonasberhe23 merged 1 commit into
rancher:masterfrom
yonasberhe23:fix_oidc_provider_test_failures_215

Conversation

@yonasberhe23
Copy link
Copy Markdown
Contributor

@yonasberhe23 yonasberhe23 commented Mar 26, 2026

Summary

Fixes #rancher/qa-tasks#2231

Updates the OIDC provider tests so they navigate to the OIDC Apps list page and navigate into the detail page from the resource table instead of using goTo() on the detail URL. Deep-linking to the detail page was tied to flaky behavior for the full-secret copy row (load-order / snapshot timing).

Screenshot/Video

image

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@yonasberhe23 yonasberhe23 added this to the v2.15.0 milestone Mar 26, 2026
@yonasberhe23 yonasberhe23 self-assigned this Mar 26, 2026
@yonasberhe23 yonasberhe23 force-pushed the fix_oidc_provider_test_failures_215 branch 2 times, most recently from 8639dcd to 820a6e6 Compare March 26, 2026 22:55
@izaac
Copy link
Copy Markdown
Contributor

izaac commented Mar 27, 2026

Can we start adding the qase() wrapper mapping to the test id in our test case management?
Example: https://github.com/rancher/dashboard/pull/17000/changes#diff-9bc5a7fefd85c9ae12c963ee728f5d8bfd586f806e09e88be8bb674af996c76cR22

@yonasberhe23 yonasberhe23 changed the title Automation: Stabilize OIDC prover tests Automation: Stabilize OIDC provider tests Mar 27, 2026
@yonasberhe23 yonasberhe23 force-pushed the fix_oidc_provider_test_failures_215 branch from 820a6e6 to d148752 Compare March 27, 2026 16:46
@yonasberhe23
Copy link
Copy Markdown
Contributor Author

Can we start adding the qase() wrapper mapping to the test id in our test case management? Example: https://github.com/rancher/dashboard/pull/17000/changes#diff-9bc5a7fefd85c9ae12c963ee728f5d8bfd586f806e09e88be8bb674af996c76cR22

@izaac yes, done. For the qase(, it(...)) wrappers in Cypress: do the numeric ids need to match real case ids in our Qase project, or can I use any sequence (e.g., continuing from the version.spec.ts example)? I’m trying to understand what breaks or misreports if the id doesn’t exist or doesn’t match the test in Qase.

@izaac
Copy link
Copy Markdown
Contributor

izaac commented Mar 27, 2026

@yonasberhe23 yes they have to match an existing TC, the behavior right now won't create new ones if they don't have an ID, I didn't dig in that specific use case where the ID doesn't match any TC in the Qase documentation to check how the Qase plugin behave, it might just ignore it as it first decorates the title and then process it in the backend.

izaac
izaac previously approved these changes Mar 27, 2026
Copy link
Copy Markdown
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@yonasberhe23 yonasberhe23 force-pushed the fix_oidc_provider_test_failures_215 branch from d148752 to 4b81c41 Compare March 27, 2026 23:46
@yonasberhe23 yonasberhe23 requested a review from izaac March 27, 2026 23:47
Copy link
Copy Markdown
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@yonasberhe23 yonasberhe23 force-pushed the fix_oidc_provider_test_failures_215 branch from 4b81c41 to 489ce97 Compare March 28, 2026 00:10
@yonasberhe23 yonasberhe23 merged commit ed4c18e into rancher:master Mar 28, 2026
35 checks passed
@yonasberhe23 yonasberhe23 deleted the fix_oidc_provider_test_failures_215 branch March 30, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants