Migrate the OIDC auth provider form to use vee-validate#17738
Open
rak-phillip wants to merge 7 commits into
Open
Migrate the OIDC auth provider form to use vee-validate#17738rak-phillip wants to merge 7 commits into
rak-phillip wants to merge 7 commits into
Conversation
71dee87 to
47d0240
Compare
codyrancher
reviewed
May 21, 2026
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
47d0240 to
213eeba
Compare
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
codyrancher
approved these changes
May 22, 2026
Member
codyrancher
left a comment
There was a problem hiding this comment.
Good with me on the technical side.
I think you still wanted to get the opinion of UX, if not I think I'd want to talk about the array list error indicator.
Member
Author
Yes, I am scheduling time to discuss this with @oboc-sts next week, as well as a few other design changes that have come through with recent PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This migrates the custom validation implementation for the OIDC auth provider to a pure vee-validate/zod implementation.
Fixes #17754
Occurred changes and/or fixed issues
Technical notes summary
In order to get this to work with
useFormfrom vee-validate, we need to find a way to sync values from the form's mixins with the composition API. This is currently accomplished via watchers that exist to sync values with the refs (99078ad). I think that the proper, long-term solution will be to migrate away from mixins to the composition API. Take care in reviewing this pattern, there's a higher risk of errors with the current approach.The validation approach using vee-validate/zod is used to demonstrate validation without the form-validation mixin or bridge in use. More information about the patterns represented in this PR can be found in the vee-validation documentation: https://vee-validate.logaretm.com/v4/guide/composition-api/typed-schema/#zod
Areas or cases that should be tested
Test configuring the Keycloak auth provider. Instructions for getting started can be found in: https://github.com/rancher/ui-internal-tools/tree/main/keycloak
Areas which could experience regressions
There are risks that the authentication logic has been unintentionally altered with this change. Edge-cases could need additional consideration. For example, what happens if the form passes validation in the UI, but the server rejects the form?
Screenshot/Video
Inline validation errors
URL validation
ArrayList validation
Checklist
Admin,Standard UserandUser Base