Skip to content

Fix failing TopLevelMenu test#17739

Merged
rak-phillip merged 1 commit into
rancher:masterfrom
rak-phillip:bugfix/top-level-menu-test
May 19, 2026
Merged

Fix failing TopLevelMenu test#17739
rak-phillip merged 1 commit into
rancher:masterfrom
rak-phillip:bugfix/top-level-menu-test

Conversation

@rak-phillip
Copy link
Copy Markdown
Member

@rak-phillip rak-phillip commented May 19, 2026

Summary

This fixes the failing TopLevelMenu unit test.

Occurred changes and/or fixed issues

  • Fix failing TopLevelMenu test

Technical notes summary

TopLevelMenu.test.ts is currently failing in `master. Based on oob discussions, it appears that two PRs addressing similar areas were merged at a similar time, causing a sort of race condition that lead to the test failure.

Areas or cases that should be tested

Unit tests should pass in CI.

Areas which could experience regressions

NA

Screenshot/Video

NA

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip merged commit 140bf8d into rancher:master May 19, 2026
82 of 92 checks passed
@rak-phillip rak-phillip deleted the bugfix/top-level-menu-test branch May 19, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants