Skip to content

Remove already disabled GitHub Action workflow#17761

Open
dirkmueller wants to merge 1 commit into
rancher:masterfrom
dirkmueller:milestone_change
Open

Remove already disabled GitHub Action workflow#17761
dirkmueller wants to merge 1 commit into
rancher:masterfrom
dirkmueller:milestone_change

Conversation

@dirkmueller
Copy link
Copy Markdown

This workflow was disabled and has zizmor failures. remove it out of a safety precaution.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

This workflow was disabled and has zizmor failures. remove it
out of a safety precaution.
Copy link
Copy Markdown
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow is pending future changes and should not be deleted.

Can you expand either here or in slack what the issues are?

@dirkmueller
Copy link
Copy Markdown
Author

This workflow is pending future changes and should not be deleted.

I would not see the slightest issue with git reverting this commit once these changes are completed?

Can you expand either here or in slack what the issues are?

The workflow file as it is today makes use of unsafe template expansion practices. While the workflow is disabled from running these are not a concern, but keeping the "dead code/workflow" around could accidentally lead to parts or all of it being reused elsewhere or accidentally being re-enabled without fixing. An explicit git removal, which will require a git revert and followup fixes seems to be a safer approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants