Remove already disabled GitHub Action workflow#17761
Conversation
This workflow was disabled and has zizmor failures. remove it out of a safety precaution.
richard-cox
left a comment
There was a problem hiding this comment.
This workflow is pending future changes and should not be deleted.
Can you expand either here or in slack what the issues are?
I would not see the slightest issue with git reverting this commit once these changes are completed?
The workflow file as it is today makes use of unsafe template expansion practices. While the workflow is disabled from running these are not a concern, but keeping the "dead code/workflow" around could accidentally lead to parts or all of it being reused elsewhere or accidentally being re-enabled without fixing. An explicit git removal, which will require a git revert and followup fixes seems to be a safer approach. |
This workflow was disabled and has zizmor failures. remove it out of a safety precaution.
Checklist
Admin,Standard UserandUser Base