Remove cypress from shell dependencies#17829
Open
rak-phillip wants to merge 1 commit into
Open
Conversation
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
f787756 to
11124b4
Compare
nwmac
approved these changes
May 27, 2026
Member
nwmac
left a comment
There was a problem hiding this comment.
Had to remind myself this is the shell package and not the top-level one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes cypress as a direct dependency of Rancher Shell.
fixes #17622
Occurred changes and/or fixed issues
Technical notes summary
I don't see a need for cypress to be included as a runtime dependency of shell after reviewing the Dashboard repo. Any project that consumes
@rancher/shellcurrently inherits cypress as a transitive runtime dependency, including projects that have no need for it. Consumers that require cypress or any other E2E test framework for their own test suite should declare it explicitly in their owndevDependencies.Areas or cases that should be tested
Existing e2e functions should still function as they did before.
CI gates should pass.
Areas which could experience regressions
Any consumers of shell that rely on cypress as a transitive dependency will need to declare cypress as their own dev dependency. One might argue that
@rancher/cypresscan be used instead1.Screenshot/Video
NA
Checklist
Admin,Standard UserandUser BaseFootnotes
https://www.npmjs.com/package/@rancher/cypress?activeTab=readme ↩