Add a new RPM handling tool in GO #654
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitor Savian <[email protected]>
brandond
reviewed
Sep 30, 2025
Comment on lines
+50
to
+58
| expect -c ' | ||
| set timeout 60 | ||
| spawn gpg --pinentry-mode loopback --force-v3-sigs --verbose --detach-sign --armor %s | ||
| expect -re "Enter passphrase.*" | ||
| send -- "%s\r" | ||
| expect eof | ||
| lassign [wait] _ _ _ code | ||
| exit $code | ||
| ' |
Member
There was a problem hiding this comment.
It feels odd to have golang running a shell that runs expect. This seems... messy. Is there a golang native way to do this?
Member
Author
There was a problem hiding this comment.
brandond
reviewed
Sep 30, 2025
Comment on lines
+480
to
+496
| cmd := exec.Command("rpm", "-qpi", localDest) | ||
| output, err := cmd.Output() | ||
| if err == nil { | ||
| lines := strings.Split(strings.TrimSpace(string(output)), "\n") | ||
|
|
||
| logrus.Info("=== RPM Package Info ===") | ||
| for _, line := range lines { | ||
| line = strings.TrimSpace(line) | ||
| if line != "" { | ||
| if strings.Contains(line, "Name") || | ||
| strings.Contains(line, "Version") || | ||
| strings.Contains(line, "Signature") || | ||
| strings.Contains(line, "Build Date") { | ||
| logrus.Infof(" %s", line) | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Is there no better interface to parsing package metadata? Are we doing anything with this data or are we basically just filtering and logging the output from the rpm query?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to refac the older rpm tool to match the pattern of the project and fix the problem that we have when we need to rerun the CI.
This new tool will have a new flag to rebuild the project if for some reason we need to rebuild the repo from the ground up.
It will delete the older repodata to clear older repodata files.
The tool will also verify if we already have a rpm with the same name, release and version and it will fail in this case