[v1.6.x][BACKPORT] seedimage: clean-up service on image download deadline (#719) #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* seedimage: clean-up service on image download deadline We used to just clean-up the Pod carrying the built image when hitting the cleanupAfterMinutes deadline. There is no need to leave the Service around, clean that up too. Fixes rancher#704 Signed-off-by: Francesco Giudici <[email protected]> * Update controllers/seedimage_controller.go Co-authored-by: Fredrik Lönnegren <[email protected]> Signed-off-by: Francesco Giudici <[email protected]> --------- Signed-off-by: Francesco Giudici <[email protected]> Signed-off-by: Francesco Giudici <[email protected]> Co-authored-by: Fredrik Lönnegren <[email protected]> (cherry picked from commit 5f2b96c)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.6.x #901 +/- ##
=========================================
Coverage ? 56.27%
=========================================
Files ? 42
Lines ? 6422
Branches ? 0
=========================================
Hits ? 3614
Misses ? 2486
Partials ? 322 ☔ View full report in Codecov by Sentry. |
fgiudici
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to just clean-up the Pod carrying the built image when hitting the cleanupAfterMinutes deadline.
There is no need to leave the Service around, clean that up too.
Fixes #704
Signed-off-by: Francesco Giudici [email protected]
Co-authored-by: Fredrik Lönnegren [email protected]
Signed-off-by: Francesco Giudici [email protected]
Signed-off-by: Francesco Giudici [email protected]
Signed-off-by: Francesco Giudici [email protected]
Co-authored-by: Fredrik Lönnegren [email protected]
(cherry picked from commit 5f2b96c)